OCPBUGS-42483: PowerVS: update capi ibmcloud c6bcd313 for 4.17 #9054

hamzy · 2024-09-26T10:58:37Z

Update the installer to use commit c6bcd313bce0fc9866e41bb9e3487d9f61c628a3 of cluster-api-provider-ibmcloud
This includes a couple of necessary Transit Gateway fixes.

openshift-ci-robot · 2024-09-26T10:58:43Z

@hamzy: This pull request references Jira Issue OCPBUGS-42483, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-42483 to depend on a bug targeting a version in 4.18.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Update the installer to use commit c6bcd313bce0fc9866e41bb9e3487d9f61c628a3 of cluster-api-provider-ibmcloud
This includes a couple of necessary Transit Gateway fixes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

hamzy · 2024-09-26T11:04:26Z

/jira refresh

openshift-ci-robot · 2024-09-26T11:04:33Z

@hamzy: This pull request references Jira Issue OCPBUGS-42483, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.17.0) matches configured target version for branch (4.17.0)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-41938 is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
dependent Jira Issue OCPBUGS-41938 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
bug has dependents

Requesting review from QA contact:
/cc @juliemathew

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

hamzy · 2024-09-26T12:06:02Z

/assign @r4f4

r4f4 · 2024-09-26T12:15:19Z

go.mod

 	k8s.io/cloud-provider-vsphere v1.30.1
 	k8s.io/klog v1.0.0
 	k8s.io/klog/v2 v2.120.1
 	k8s.io/utils v0.0.0-20240310230437-4693a0247e57
 	libvirt.org/go/libvirtxml v1.10002.0
-	sigs.k8s.io/cluster-api v1.7.3
+	sigs.k8s.io/cluster-api v1.8.2


We should also bump the capi binary to the same version in cluster-api/cluster-api. Building against one version and running another is asking for trouble.
When we bump, we need to make sure all the other providers still work, so this PR needs to be thoroughly tested.

@r4f4 Updated...

I don't see the update. Maybe you forgot to push the new commit?

Weird. It is here locally and was pushed.

hamzy:hamzy-installer$ grep 'sigs.k8s.io/cluster-api v1.8.2' go.mod sigs.k8s.io/cluster-api v1.8.2 hamzy:hamzy-installer$ git status On branch PowerVS-Update-417-CAPI-ibmcloud-c6bcd313 Your branch is up to date with 'origin/PowerVS-Update-417-CAPI-ibmcloud-c6bcd313'.

Forgot to also modify cluster-api/cluster-api/go.mod :(
Thanks!

hamzy · 2024-09-26T17:02:10Z

/retest-required

r4f4 · 2024-09-26T18:03:30Z

/hold

Let's fix the capi mismatch in the master branch first.

hamzy · 2024-09-26T18:24:25Z

/test e2e-powervs-ovn

r4f4 · 2024-09-26T18:54:53Z

Fix proposed in #9055

hamzy · 2024-09-26T20:30:45Z

/test e2e-ibmcloud-ovn

hamzy · 2024-09-27T13:22:45Z

/test e2e-powervs-ovn

openshift-ci · 2024-09-27T17:20:50Z

@hamzy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws-ovn-shared-vpc-custom-security-groups	`6240605`	link	false	`/test e2e-aws-ovn-shared-vpc-custom-security-groups`
ci/prow/e2e-aws-ovn-imdsv2	`6240605`	link	false	`/test e2e-aws-ovn-imdsv2`
ci/prow/altinfra-e2e-aws-ovn-localzones	`6240605`	link	false	`/test altinfra-e2e-aws-ovn-localzones`
ci/prow/e2e-aws-ovn-fips	`6240605`	link	false	`/test e2e-aws-ovn-fips`
ci/prow/okd-e2e-agent-ha-dualstack	`6240605`	link	false	`/test okd-e2e-agent-ha-dualstack`
ci/prow/e2e-aws-ovn-heterogeneous	`6240605`	link	false	`/test e2e-aws-ovn-heterogeneous`
ci/prow/okd-e2e-agent-sno-ipv6	`6240605`	link	false	`/test okd-e2e-agent-sno-ipv6`
ci/prow/e2e-aws-ovn-single-node	`6240605`	link	false	`/test e2e-aws-ovn-single-node`
ci/prow/okd-e2e-agent-compact-ipv4	`6240605`	link	false	`/test okd-e2e-agent-compact-ipv4`
ci/prow/e2e-aws-ovn-shared-vpc-edge-zones	`6240605`	link	false	`/test e2e-aws-ovn-shared-vpc-edge-zones`
ci/prow/e2e-aws-ovn-edge-zones	`6240605`	link	false	`/test e2e-aws-ovn-edge-zones`
ci/prow/e2e-gcp-ovn-byo-vpc	`6240605`	link	false	`/test e2e-gcp-ovn-byo-vpc`
ci/prow/e2e-ibmcloud-ovn	`6240605`	link	false	`/test e2e-ibmcloud-ovn`

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

hamzy · 2024-09-30T13:08:08Z

@r4f4 Can this progress now that #9055 has been approved?

r4f4 · 2024-09-30T19:22:48Z

/hold cancel

r4f4 · 2024-09-30T19:23:09Z

/approve

openshift-ci · 2024-09-30T19:25:46Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: r4f4

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [r4f4]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

hamzy · 2024-09-30T19:59:28Z

@gpei Hello, could you please label cherry-pick-approved?

patrickdillon · 2024-09-30T20:43:41Z

/test e2e-openstack-ovn e2e-vsphere-ovn e2e-nutanix-ovn

patrickdillon · 2024-09-30T20:44:00Z

/label backport-risk-assessed

mjturek · 2024-10-01T21:07:41Z

/lgtm

gpei · 2024-10-05T06:50:46Z

/label cherry-pick-approved

openshift-ci-robot · 2024-10-05T07:45:11Z

/retest-required

Remaining retests: 0 against base HEAD 2a5919d and 2 for PR HEAD 6240605 in total

openshift-ci-robot · 2024-10-05T11:54:47Z

@hamzy: Jira Issue OCPBUGS-42483: All pull requests linked via external trackers have merged:

openshift/installer#9054

Jira Issue OCPBUGS-42483 has been moved to the MODIFIED state.

In response to this:

Update the installer to use commit c6bcd313bce0fc9866e41bb9e3487d9f61c628a3 of cluster-api-provider-ibmcloud
This includes a couple of necessary Transit Gateway fixes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-bot · 2024-10-05T14:26:12Z

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-altinfra
This PR has been included in build ose-installer-altinfra-container-v4.17.0-202410051335.p0.ga1b46a5.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-10-05T14:32:13Z

[ART PR BUILD NOTIFIER]

Distgit: ose-baremetal-installer
This PR has been included in build ose-baremetal-installer-container-v4.17.0-202410051335.p0.ga1b46a5.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-10-05T14:38:12Z

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-terraform-providers
This PR has been included in build ose-installer-terraform-providers-container-v4.17.0-202410051335.p0.ga1b46a5.assembly.stream.el9.
All builds following this will include this PR.

openshift-bot · 2024-10-05T15:53:21Z

[ART PR BUILD NOTIFIER]

Distgit: ose-installer-artifacts
This PR has been included in build ose-installer-artifacts-container-v4.17.0-202410051335.p0.ga1b46a5.assembly.stream.el9.
All builds following this will include this PR.

PowerVS: Include latest ibmcloud-infrastructure-components.yaml

39f8e62

openshift-ci bot requested review from barbacbd and jhixson74 September 26, 2024 11:00

openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Sep 26, 2024

openshift-ci bot requested a review from juliemathew September 26, 2024 11:04

openshift-ci bot assigned r4f4 Sep 26, 2024

r4f4 suggested changes Sep 26, 2024

View reviewed changes

hamzy force-pushed the PowerVS-Update-417-CAPI-ibmcloud-c6bcd313 branch from 8a3cf7b to 8536700 Compare September 26, 2024 12:55

hamzy added 2 commits September 26, 2024 09:27

PowerVS: Vendoring go.* changes

c64cac0

PowerVS: Vendoring the rest changes

6240605

hamzy force-pushed the PowerVS-Update-417-CAPI-ibmcloud-c6bcd313 branch from 8536700 to 6240605 Compare September 26, 2024 14:29

openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2024

openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 30, 2024

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 30, 2024

openshift-ci bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Sep 30, 2024

openshift-ci bot assigned mjturek Oct 1, 2024

openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Oct 1, 2024

openshift-ci bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 5, 2024

openshift-merge-bot bot merged commit a1b46a5 into openshift:release-4.17 Oct 5, 2024
33 of 43 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

OCPBUGS-42483: PowerVS: update capi ibmcloud c6bcd313 for 4.17 #9054

OCPBUGS-42483: PowerVS: update capi ibmcloud c6bcd313 for 4.17 #9054

hamzy commented Sep 26, 2024

openshift-ci-robot commented Sep 26, 2024

hamzy commented Sep 26, 2024

openshift-ci-robot commented Sep 26, 2024

hamzy commented Sep 26, 2024

r4f4 Sep 26, 2024

hamzy Sep 26, 2024

r4f4 Sep 26, 2024

hamzy Sep 26, 2024 •

edited

Loading

hamzy Sep 26, 2024

hamzy commented Sep 26, 2024

r4f4 commented Sep 26, 2024

hamzy commented Sep 26, 2024

r4f4 commented Sep 26, 2024

hamzy commented Sep 26, 2024

hamzy commented Sep 27, 2024

openshift-ci bot commented Sep 27, 2024 •

edited

Loading

hamzy commented Sep 30, 2024

r4f4 commented Sep 30, 2024

r4f4 commented Sep 30, 2024

openshift-ci bot commented Sep 30, 2024

hamzy commented Sep 30, 2024

patrickdillon commented Sep 30, 2024

patrickdillon commented Sep 30, 2024

mjturek commented Oct 1, 2024

gpei commented Oct 5, 2024

openshift-ci-robot commented Oct 5, 2024

openshift-ci-robot commented Oct 5, 2024

openshift-bot commented Oct 5, 2024

openshift-bot commented Oct 5, 2024

openshift-bot commented Oct 5, 2024

openshift-bot commented Oct 5, 2024

OCPBUGS-42483: PowerVS: update capi ibmcloud c6bcd313 for 4.17 #9054

OCPBUGS-42483: PowerVS: update capi ibmcloud c6bcd313 for 4.17 #9054

Conversation

hamzy commented Sep 26, 2024

openshift-ci-robot commented Sep 26, 2024

hamzy commented Sep 26, 2024

openshift-ci-robot commented Sep 26, 2024

hamzy commented Sep 26, 2024

r4f4 Sep 26, 2024

Choose a reason for hiding this comment

hamzy Sep 26, 2024

Choose a reason for hiding this comment

r4f4 Sep 26, 2024

Choose a reason for hiding this comment

hamzy Sep 26, 2024 • edited Loading

Choose a reason for hiding this comment

hamzy Sep 26, 2024

Choose a reason for hiding this comment

hamzy commented Sep 26, 2024

r4f4 commented Sep 26, 2024

hamzy commented Sep 26, 2024

r4f4 commented Sep 26, 2024

hamzy commented Sep 26, 2024

hamzy commented Sep 27, 2024

openshift-ci bot commented Sep 27, 2024 • edited Loading

hamzy commented Sep 30, 2024

r4f4 commented Sep 30, 2024

r4f4 commented Sep 30, 2024

openshift-ci bot commented Sep 30, 2024

hamzy commented Sep 30, 2024

patrickdillon commented Sep 30, 2024

patrickdillon commented Sep 30, 2024

mjturek commented Oct 1, 2024

gpei commented Oct 5, 2024

openshift-ci-robot commented Oct 5, 2024

openshift-ci-robot commented Oct 5, 2024

openshift-bot commented Oct 5, 2024

openshift-bot commented Oct 5, 2024

openshift-bot commented Oct 5, 2024

openshift-bot commented Oct 5, 2024

hamzy Sep 26, 2024 •

edited

Loading

openshift-ci bot commented Sep 27, 2024 •

edited

Loading